Check for complete pattern matches later in the target text #1900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to find the best match when trying to match "so" against "schemas/source_files.ex". Without this, bescause the 's' in "so" matches against "schemas", we never find the complete match against "source_files" later in the target. Look for a later total match and add it to the list if it is at least as good as the computed partial match so far. If we also have a partial-match continuation, prefer the longer of the 2 choices.
iteratee
force-pushed
the
kb/later_complete_match
branch
from
6123f41
to
22082ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to find the best match when trying to match "so" against "schemas/source_files.ex". Without this, bescause the 's' in "so" matches against "schemas", we never find the complete match against "source_files" later in the target. Look for a later total match and add it to the list if it is at least as good as the computed partial match so far. If we also have a partial-match continuation, prefer the longer of the 2 choices, or the single-piece match if they are the same length.