Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement InterpreterProxy #175

Merged
merged 164 commits into from
Feb 9, 2024
Merged

Implement InterpreterProxy #175

merged 164 commits into from
Feb 9, 2024

Conversation

MariusDoe
Copy link
Contributor

@MariusDoe MariusDoe commented Dec 21, 2023 •
edited
Loading

InterpreterProxy for TruffleSqueak

This is the first step towards a working InterpreterProxy for trufflesqueak.

This PR is part of the project InterpreterProxy for TruffleSqueak in the Reverse Engineering lecture (WT 2023/24) at HPI.

Try it

Watch the demo

screencast.mp4

Note: Manually copying plugins from OsVM is no longer needed since a6be20b

  1. get Opensmalltalk-VM
  2. copy a supported plugin like SqueakSSL.so from ..Squeak/bin/ to ..trufflesqueak/languages/smalltalk/lib/
  3. Try the plugins
SqueakSSLTest run: #testFaceBookAPI.
UUIDPrimitivesTest run: #testCreation.

Additions

Description Files
Add native-side InterpreterProxy and headers InterpreterProxy.c, include/, CMakeLists.txt
Add node to handle ffi calls to external plugins PrimExternalCallNode.java
InterpreterProxy method and state implementation InterpreterProxy.java
Utility for marshalling closures and interfacing with NFI NFIUtils.java
Wrappers for native array types NativeObjectStorage.java, ByteStorage.java,
IntStorage.java, LongStorage.java,
ShortStorage.java, PostPrimitiveCleanup.java

Modifications

Description Files
Add sources of interpreter proxy to build chain mx_trufflesqueak.py, suite.py
Adjust checkstyle to allow for suppressed warnings for
field that cannot be made local		 .checkstyle_checks.xml
Add helper for uncached execute of new object node SqueakObjectNewNode.java
Hook named primitive lookup to create new external call node PrimitiveNodeFactory.java
Create helper function to get garbage collection count for alle beans MiscUtils.java
Add helpers for allocation of primitive array types UnsafeUtils.java

Coverage of Interpreter Proxy methods (As of: 09.02.2024)

  • Methods implemented: 70/136
  • 10 Plugins covered: ClipboardExtendedPlugin, DropPlugin, FileDialogPlugin, InternetConfigPlugin, LocalePlugin, MIDIPlugin, SHA256Plugin, SecurityPlugin, SqueakSSL, UUIDPlugin

methods and plugins covered

DieKautz and others added 30 commits November 5, 2023 22:10
@DieKautz
[skip ci] Test NFI for non-existent named primitives
a3a9490
@MariusDoe
[skip ci] Add initial createInterpreterProxy function in C
a5bb9a0
@DieKautz
Add stub methods for interpreter proxy
63632dc 
[skip ci]
@MariusDoe
Implement ByteStorage using extended UnsafeUtils and add TruffleExecu…
34cafd2 
…table
@DieKautz
Set absolute library path (for now)
a4a53ad 
[skip ci]
@DieKautz
Create InterpreterProxy and extract inner classes
bb0e12b
@DieKautz
Fix argument
ea1f4ce
@DieKautz
Generalize ByteStorage
25f9726
@DieKautz
Remove redundant fully-qualified class name
4ba75fc
@DieKautz
Do not assume ByteStorage
f88ae6d
@DieKautz
Get correct byteSize for storage type
f340233
@DieKautz
Return isBytes by storage type
cb53d61
@DieKautz
Stub symbols needed to support SqueakSSL
bcc3f00 
[skip ci]
@MariusDoe
Towards using SqueakSSL.so
2185699 
* Add numReceiverAndArguments to InterpreterProxy
* Turn InterpreterProxy into a singleton with mutable members
  frame and numReceiverAndArguments
* objectRegistry is now effectively static, so all primitive
  invocations share an oop namespace
* Implement most InterpreterProxy stubs required for SqueakSSL.so
@MariusDoe
Fix stack pointer before running C code
d2498bb
@MariusDoe
Use MaterializedFrames
36a22fa 
[skip ci]
@MariusDoe
Fix off-by-one in pre-call stackPointer adjustment
78c60d1 
[skip ci]
@MariusDoe
Fix stack access using stackPointer
042a901 
[skip ci]
@MariusDoe
Only load libraries once
903e974
@MariusDoe
Add NFIUtils.loadMember
1f6ce90 
[skip ci]
@MariusDoe
Add loading of function symbols
87ca9d3 
[skip ci]
@MariusDoe
Fix handling of return values
1e4983b 
[skip ci]
@MariusDoe
Keep TruffleExecutables in memory
ff31a64 
[skip ci]
@DieKautz
Make ffi.native use CMakeNinjaProject
0f5a24d
@DieKautz
Format
44cffa8
@DieKautz
Load nfi libraries from image path
8a9252c
@DieKautz
Import is not actually unused
5dae186 
[skip ci]
@MariusDoe
Prevent NFI closures from being freed
d7025ec 
[skip ci]
@DieKautz
Add missing stubs from BitBlt support
b1cb5c2 
[skip ci]
@MariusDoe
Implement some stubs and refactor
fd3453b
MariusDoe and others added 27 commits February 8, 2024 20:38
@MariusDoe
Implement stringForCString
212b4e2
@MariusDoe
Add missing import for BooleanObject
782e45d
@MariusDoe
Implement class*
77c1ccb
@MariusDoe
Implement booleanValueOf
7a0476a
@fniephaus
Correct copyright headers and import order
7b680ae
@fniephaus
Register unused but implemented proxy methods
e86fa72
@fniephaus
Minor cleanups
4c7338d
@fniephaus
Add false and true object for LocalePlugin
d88f0f9
@fniephaus
Re-use plugins from OpenSmalltalkVM
a6be20b 
Initially, only SqueakSSL and LocalePlugin for Linux amd64/aarch64 and Windows amd64 are included.
@fniephaus
Implement showDisplayBitsLeftTopRightBottom
a59cd4f
@fniephaus
Address ECJ warnings
4a95838
@fniephaus
Add InterpreterProxy and loaded modules to context
cf2f6b1 
They are context-specific and cannot be re-used in a different context, which for example happens during testing.
@MariusDoe
Fix ordering of methods
3d16b0c
@MariusDoe
Properly implement stringForCString
be4897c
@MariusDoe
Readd push
763ee32
@fniephaus
Fix ECJ warnings
54c6482
@fniephaus
Upgrade actions used in workflow for Node 20
a6b073e
@MariusDoe
Add final to instanceof variable declarations
dac1d2d
@DieKautz
Fix 0-based error code and do not overwrite
6eae7fc
@DieKautz
Add 32bit casts
0a657e2
@DieKautz
Fix long return values
5d5e92d
@fniephaus
Move loadedLibraries into InterpreterProxy
a577ca2
@fniephaus
Drop PostPrimitiveCleanup
3889b4b
@fniephaus
Adjust visibility
9eaa707
@DieKautz
Implement positive64BitIntegerFor
fac45ec
@fniephaus
Fix ECJ warnings
79e1ded
@fniephaus
Move loadedLibraries back into context
692a26c 
There seems to be some odd loading order problem on Windows.
@fniephaus fniephaus force-pushed the wip/interpreter-proxy branch from 381e07c to 692a26c Compare February 9, 2024 14:30
@fniephaus fniephaus merged commit 7b87b46 into dev Feb 9, 2024
16 of 17 checks passed
@fniephaus fniephaus deleted the wip/interpreter-proxy branch February 9, 2024 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DieKautz DieKautz DieKautz left review comments

@fniephaus fniephaus fniephaus left review comments

Assignees

@DieKautz DieKautz

@MariusDoe MariusDoe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MariusDoe @fniephaus @DieKautz