Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue/677 privacy screen #690

Merged
merged 9 commits into from
Dec 27, 2023
Merged

Issue/677 privacy screen #690

merged 9 commits into from
Dec 27, 2023

Conversation

tamslo
Copy link
Collaborator

@tamslo tamslo commented Dec 27, 2023

Closes #677

@github-actions github-actions bot added the P: App Project: App label Dec 27, 2023
Copy link

codecov bot commented Dec 27, 2023

Codecov Report

Attention: 22 lines in your changes are missing coverage. Please review.

Comparison is base (195de4d) 57.14% compared to head (2c49c32) 56.85%.

❗ Current head 2c49c32 differs from pull request most recent head 9e4d56d. Consider uploading reports for the commit 9e4d56d to get more accurate results

Files Patch % Lines
app/lib/common/widgets/lifecycle_observer.dart 0.00% 10 Missing ⚠️
app/lib/app.dart 0.00% 8 Missing ⚠️
app/lib/common/utilities/routing_utils.dart 0.00% 2 Missing ⚠️
app/lib/secure/pages/secure.dart 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #690      +/-   ##
==========================================
- Coverage   57.14%   56.85%   -0.30%     
==========================================
  Files          97      101       +4     
  Lines        2079     2102      +23     
==========================================
+ Hits         1188     1195       +7     
- Misses        891      907      +16     
Flag Coverage Δ
app 54.26% <50.00%> (-0.28%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tamslo tamslo merged commit d340c01 into main Dec 27, 2023
5 checks passed
@tamslo tamslo deleted the issue/677-privacy-screen branch December 27, 2023 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P: App Project: App
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Only show logo in overview thumbnail
1 participant