Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#637): show unknown guidelines as green #659

Merged
merged 1 commit into from
Sep 8, 2023

Conversation

tamslo
Copy link
Collaborator

@tamslo tamslo commented Sep 8, 2023

Closes #637

Changes

  • Show unknown warning as green, not gray
  • Refactoring: introduce method to get warning level from guideline or WarningLevel.none, if guideline is ´null´

@github-actions github-actions bot added the P: App Project: App label Sep 8, 2023
@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Patch coverage: 81.25% and project coverage change: +0.09% 🎉

Comparison is base (2eb5646) 57.08% compared to head (3ff1a72) 57.18%.
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #659      +/-   ##
==========================================
+ Coverage   57.08%   57.18%   +0.09%     
==========================================
  Files          75       76       +1     
  Lines        1715     1719       +4     
==========================================
+ Hits          979      983       +4     
  Misses        736      736              
Flag Coverage Δ
app 54.00% <81.25%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
app/lib/common/constants.dart 40.00% <ø> (ø)
app/lib/common/models/drug/drug.dart 37.50% <0.00%> (-1.64%) ⬇️
app/lib/common/models/drug/warning_level.dart 100.00% <100.00%> (ø)
...pages/drug/widgets/annotation_cards/guideline.dart 91.66% <100.00%> (ø)
app/lib/common/theme.dart 64.44% <100.00%> (+0.80%) ⬆️
app/lib/common/utilities/guideline_utils.dart 100.00% <100.00%> (ø)
...ommon/widgets/drug_list/drug_items/drug_cards.dart 93.33% <100.00%> (+2.02%) ⬆️

☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.

@tamslo tamslo closed this Sep 8, 2023
@tamslo tamslo reopened this Sep 8, 2023
@tamslo tamslo merged commit 2a34216 into main Sep 8, 2023
10 checks passed
@tamslo tamslo deleted the issue/637-green-for-unknown branch September 8, 2023 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P: App Project: App
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show indeterminate/unknown genotypes as "light green" and standard dosage
1 participant