Add links to LinkedIn and VSC website to nav bar #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smoors
approved these changes
Aug 31, 2023
|
Yeah, I agree that it is not perfect. But I would keep external links on the right and link to frontpage on the left. Ideally it would be less confusing to have a custom logo for the VSC docs and use that in the top left corner. And also have a custom little square for VSC and use that for the link to the website. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #338
Preview in https://vscdocumentationbeta.readthedocs.io
Adding the logo for X is quite hacky because it is not available in the vendored version of FontAwesome in the pydata theme. So I added it manually as an image an emulated the behaviour of the other icons with CSS.
Whenever we get a version of pydata with a recent enough FontAwesome, this can be replaced by the simple method using icons.
Regarding the link to the VSC website, I chose a home icon for it. I didn't find any better option in the free FontAwesome collection that would convey the message of a link to a parent website.