Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/ondemand kul #335

Closed
wants to merge 7 commits into from
Closed

Feature/ondemand kul #335

wants to merge 7 commits into from

Conversation

w-lampaert
Copy link
Contributor

No description provided.

stevenvdb
stevenvdb requested changes Aug 9, 2023
View reviewed changes
Copy link
Collaborator

@stevenvdb stevenvdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from some minor changes, this is ok for me.

Do note that, if I understood correctly, we have been asked to not merge changes into the master branch until #334 is completed. Maybe ping @lexming to ask what the status is.

source/leuven/services/openondemand.rst Outdated Show resolved Hide resolved
source/leuven/services/openondemand.rst Outdated Show resolved Hide resolved
@jooghe jooghe mentioned this pull request Sep 1, 2023
Merged
@jooghe
Copy link
Contributor

jooghe commented Sep 1, 2023

replaced by PR #344

@jooghe jooghe closed this Sep 1, 2023
@lexming lexming mentioned this pull request Sep 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevenvdb stevenvdb stevenvdb requested changes

@avapirev avapirev avapirev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@w-lampaert @jooghe @stevenvdb @avapirev