Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix region transfer with object static partitioning #214

Merged
merged 3 commits into from
Nov 26, 2024

Conversation

houjun
Copy link
Member

@houjun houjun commented Nov 1, 2024

Related Issues / Pull Requests

#215

Description

Fix a bug when all dim lengths of an object are smaller than the number of servers when object static partitioning (default) is used.

What changes are proposed in this pull request?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality not to work as expected; for instance, examples in this repository must be updated too)
  • This change requires a documentation update

Checklist:

  • My code modifies existing public API, or introduces new public API, and I updated or wrote docstrings
  • I have commented my code
  • My code requires documentation updates, and I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@houjun houjun changed the title Update pdc_region_transfer.c Fix region transfer with object static partitioning Nov 4, 2024
@houjun houjun marked this pull request as ready for review November 4, 2024 16:45
Copy link
Member

@jeanbez jeanbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to either merge the #213 first which corrects the libfabric dependency in Perlmutter or also fix it here for the CI to complete.

Fix issue with Perlmutter CI libfabric module
@jeanbez jeanbez merged commit 25db7c1 into develop Nov 26, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants