switching this lesson to the new Carpentries Workbench Template #23
Conversation
|
Assignment received, will try to find some bandwidth for this soon. |
There was a problem hiding this comment.
Thank you @razoumov, it's great to see activity on Chapel! It hasn't been updated in a while, and I have avoided scrutinizing since there has not been an active maintainer for several years. My review comments apply to the Workbench conversion (which seems fine), and some edits to the old and revised content for clarity of exposition. I appreciate your efforts on this material.
|
Sounds good! Go ahead and "resolve" anything you consider completed, through discussion or commits.
…On Sep 13, 2024, 5:46 PM, at 5:46 PM, Alex Razoumov ***@***.***> wrote:
@razoumov commented on this pull request.
On CITATION.cff:
Thank you @tkphd for your thorough review! I will be updating this
branch and replying to individual conversations (all 64) in this PR,
and if you are happy with the file changes, please mark them as
resolved -- does this work for you? Alternatively, I could mark them
"resolved" as I work on them, but then you will likely miss some
details. Let me know what you prefer.
hpc-carpentry/hpc-chapel lessons were originally created by myself and
Juan Zuniga. Jeff Stafford did a lot of additional formatting and
polishing, and many people have contributed since then. I modified
CITATION and CITATION.cff -- does this work? Planning to include more
authors when we add new chapters/tracks in the next few months.
--
Reply to this email directly or view it on GitHub:
#23 (comment)
You are receiving this because you were mentioned.
Message ID:
***@***.***>
|
…viously deleted Exercise 2
… instructions are more of a placeholder for someone to test
… module suggestion; remove .checklist
…e, n -> outputFrequency
…bles with type and/or value
…h the number of cores
…clarify all ther terms)
…scussion with an example that will block for sure, and provide the solution/explanation of why it blocks
…dditional restrictions**
…laration and subsetting
|
Hi Trevor @tkphd - I believe I went through all the points in your review, closed the ones that have been resolved through a commit, and commented on the rest. At this point my preference would be to merge this PR into the repo, to publish in the new workbench format, and open new issues for any unresolved points in this PR if needed. I know there is an ongoing discussion about using Quarto over the Varnish engine (looking at the meeting agenda, have not attended the meetings for a while). If there is an organization-wide HPC Carpentry transition to Quarto, I am happy to adopt it for HPC Chapel in a future PR (that someone more familiar with Quarto should create), but at this point I would prefer to merge the already committed extensive set of changes into the repo. What are your thoughts? |
There was a problem hiding this comment.
I don't think the LICENSE needs a separate section for software, as there are no software source code artifacts in the repository, only code-blocks in the Markdown-formatted plain text. This falls under normal copyright, not software licensing, but is also not hugely important.
| - "Know how to define and use data stored as variables." | ||
| :::::::::::::::::::::::::::::::::::::::::::::::: | ||
|
|
||
| Using basic maths in Chapel is fairly intuitive. Try compiling the following code to see |
There was a problem hiding this comment.
Contextualize this for beginners, like the Ep. 1 examples:
Open a text editor and populate the document with these lines; save it as operators.chpl; compile and run with the following command.
| It can span as many lines as you want! | ||
| (like this) */ | ||
| ``` | ||
|
|
There was a problem hiding this comment.
Better practice would make that edit, or create a block comment describing what the code does in operators.chpl, then recompile & run. This will catch a few learners' typos.
|
|
||
|
|
||
|
|
||
|
|
|
|
||
| ```chpl | ||
| const test = 100; | ||
| writeln('The value of test is ', test, ' and its type is ', test.type:string); |
There was a problem hiding this comment.
Neato, and please talk through the syntax of test.type:string
Auto-generated via {sandpaper}
Source : 89c58a3
Branch : main
Author : Trevor Keller <[email protected]>
Time : 2024-10-08 19:13:39 +0000
Message : Merge pull request #23 from hpc-carpentry/dev-workbench
switching this lesson to the new Carpentries Workbench Template
Auto-generated via {sandpaper}
Source : cf65a56
Branch : md-outputs
Author : GitHub Actions <[email protected]>
Time : 2024-10-08 19:15:25 +0000
Message : markdown source builds
Auto-generated via {sandpaper}
Source : 89c58a3
Branch : main
Author : Trevor Keller <[email protected]>
Time : 2024-10-08 19:13:39 +0000
Message : Merge pull request #23 from hpc-carpentry/dev-workbench
switching this lesson to the new Carpentries Workbench Template
|
@razoumov I merged this PR, and the build "succeeded," but the rendered site does not look correct: |
|
Thank you @tkphd for merging this pull request! I restarted the Pages built process (switched the site source to None and then back to gh-pages), and it now built the website properly https://www.hpc-carpentry.org/hpc-chapel |
|
Excellent! Thanks @razoumov |
Auto-generated via `{sandpaper}`
Source : cf65a56
Branch : md-outputs
Author : GitHub Actions <[email protected]>
Time : 2024-10-08 19:15:25 +0000
Message : markdown source builds
Auto-generated via {sandpaper}
Source : 89c58a3
Branch : main
Author : Trevor Keller <[email protected]>
Time : 2024-10-08 19:13:39 +0000
Message : Merge pull request #23 from hpc-carpentry/dev-workbench
switching this lesson to the new Carpentries Workbench Template
As discussed at #22, doing this via a PR.