Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed typo #1514

Merged
merged 2 commits into from
Nov 22, 2024
Merged

Fixed typo #1514

merged 2 commits into from
Nov 22, 2024

Conversation

Moogamouth
Copy link
Contributor

Fixed typo

Issue: I literally just changed an m to an n. Does that really need an issue?

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • issue was opened to discuss proposed changes before starting implementation. It is important do discuss changes before implementing them (Why should we add it? How should it work? How should it look? Where will it be? ...).
  • during development, node version specified in package.json was used (ie using nvm).
  • package versions and package-lock.json were not changed (npm install --no-save).
  • app version number was not changed.
  • all new code has tests to ensure against regressions.
  • npm run lint reports no offenses.
  • npm run test is error-free.
  • README and CHANGELOG were updated accordingly.
  • after PR is approved, all commits in it are squashed

I know I'm repeatedly being lazy, but I do not feel like dealing with all these issues and check boxes and tests. I literally just fixed a single letter typo! Please just accept my pull request. Apologies for my laziness. Thank you for reading this.

Description of the Change

Fixed a typo. Changed "mimiBreakAudio" to "miniBreakAudio"

Verification Process

I did not bother to test it, but I fixed a single letter typo and I think there is no reason why it should work any worse than before.

Other information

Copy link
Owner

@hovancik hovancik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch :)

@hovancik hovancik merged commit 8c56b80 into hovancik:trunk Nov 22, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants