Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve DND detection across platforms #1383

Merged
merged 1 commit into from
Nov 4, 2023
Merged

Improve DND detection across platforms #1383

merged 1 commit into from
Nov 4, 2023

Conversation

hovancik
Copy link
Owner

@hovancik hovancik commented Oct 13, 2023

closes #1039
closes #1080

@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

Attention: 34 lines in your changes are missing coverage. Please review.

Comparison is base (671a1f1) 77.18% compared to head (e0bcc41) 71.14%.

Additional details and impacted files
@@            Coverage Diff             @@
##            trunk    #1383      +/-   ##
==========================================
- Coverage   77.18%   71.14%   -6.05%     
==========================================
  Files          14       14              
  Lines         320      350      +30     
==========================================
+ Hits          247      249       +2     
- Misses         73      101      +28     
Files Coverage Δ
app/utils/dndManager.js 33.87% <8.10%> (-25.51%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hovancik hovancik force-pushed the fix/rip-out-ens branch 2 times, most recently from cfe6e6f to 9339f72 Compare October 27, 2023 11:38
@hovancik hovancik force-pushed the fix/rip-out-ens branch 4 times, most recently from 3ce2df9 to 626ccc6 Compare November 4, 2023 16:18
@hovancik hovancik merged commit 3c85cfc into trunk Nov 4, 2023
6 of 8 checks passed
@hovancik hovancik deleted the fix/rip-out-ens branch November 4, 2023 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant