-
Notifications
You must be signed in to change notification settings - Fork 2
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
1 parent
72d7b4f
commit 89daa25
Showing
3 changed files
with
16 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
89daa25
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@spwoodcock I think the correct version should be
0.2.0-rc.5
https://semver.npmjs.com/#syntax-examples
89daa25
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure that's the
NPM
convention for pre-release naming, but personally I disagree with it.rc
should be used for release candidates IMO, in line with many other tools and package managers (like pypi for example).There is no specific convention for pre-release naming in the semver spec https://semver.org/
We use commitizen for most of the modules I have configured, which uses
a
for alphab
for beta,rc
for release candidate. If you feel strongly about this, then we can of course deviate from this for this package, but I would prefer the consistency 👍