Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement About page components from the Figma design #6050

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

HelNershingThapa
Copy link
Contributor

Resolves #6019

This pull request addresses the task of translating the Figma design for the About page into code. It Introduced UI components for all sections of the About page.

Things to Do to Consider This PR Done

  • Text Revision: Review and revise the text content for the entire page.
  • Interest Cards: Create and add cards for all interest options within the "We Are Creating Change" section. Implement horizontal scrolling for a user-friendly interface.
  • Statistics: Determine and incorporate the specific statistics that must be displayed on the page.
  • Communication Channels: Integrate and link the communication channels from the "Get In Touch" section to ensure users can easily connect with us.
  • Bing Icon Fix: Address the issue where the Bing Icon appears disarranged on larger screens and implement a solution to ensure proper alignment and display.

Screenshots:
Desktop:
screencapture-127-0-0-1-3000-about-2023-09-05-10_33_00

Tablet:
screencapture-127-0-0-1-3000-about-2023-09-05-10_33_25

Mobile:
screencapture-127-0-0-1-3000-about-2023-09-05-10_33_45

- Refactored the homepage by creating a reusable component, `OverlayListDisplay`, for the "Who Is Mapping" section. This component efficiently handles content display for both dark and light variants. Integrated the new `OverlayListDisplay` component into the `WhoIsMapping` component section.
- Replaced all organization PNG icons in the assets folder with corresponding SVG icons sourced from the Figma design. Additionally, updated Bing's icon to a newer version. Introduced the `isShowWhiteLogo` prop for all SVG icons to control the display of white logos on the homepage and original logos on the about page.
@sonarcloud
Copy link

sonarcloud bot commented Sep 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improvements to about page
2 participants