Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/pre-commit hook and pdm integration #257

Merged
merged 2 commits into from
Jun 25, 2024

Conversation

nifedara
Copy link
Contributor

What does this PR do?

Resolves Integrate Pre-commit Hooks and Dependency Management

Consideration

  • These are sample hooks. More can be added
  • Adds documentation about how to install pdm

Why choices of pre-commit hook

  • check-yaml: Loads all yaml files to verify the syntax
  • end-of-file-fixer: Makes sure files end in a newline and only a newline
  • trailing-whitespace: Trims trailing whitespace. ..more
  • ruff: Fast Python linter and code formatter, written in Rust.
  • commitizen: Enforces writing descriptive commits and makes commits easier to read

Why pdm for dependency management

  • pdm: a modern Python package and dependency manager that supports the latest PEP standards

@nifedara nifedara marked this pull request as ready for review June 22, 2024 09:15
@nifedara
Copy link
Contributor Author

@kshitijrajsharma

@kshitijrajsharma
Copy link
Member

Running the workflow to test build

@kshitijrajsharma kshitijrajsharma merged commit 62dc33b into hotosm:master Jun 25, 2024
1 check passed
jeafreezy pushed a commit to jeafreezy/fAIr that referenced this pull request Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate Pre-commit Hooks and Dependency Management methods on the backend
2 participants