Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(validators): content-type is required on requests with json validators #540

Merged
merged 2 commits into from
Nov 29, 2024

Conversation

Soviut
Copy link
Contributor

@Soviut Soviut commented Nov 28, 2024

Added example when testing using app.request() which is what originally tripped me up.

This relates to the warning added here honojs/hono#3707

Added example when testing using app.request() which is what originally tripped me up.
@Soviut Soviut changed the title docs: content-type is required on requests with json validators docs(validators): content-type is required on requests with json validators Nov 28, 2024
Copy link
Member

@yusukebe yusukebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yusukebe
Copy link
Member

@Soviut

Thanks! Looks good to me.

@yusukebe yusukebe merged commit a471fa1 into honojs:main Nov 29, 2024
@Soviut
Copy link
Contributor Author

Soviut commented Nov 29, 2024

@yusukebe I realized in my haste I accidentally made a app.get() in my example app but the test was for a POST request. I'll do a follow up hotfix.

@Soviut Soviut mentioned this pull request Nov 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants