fix bun test example #236
fix bun test example #236
Conversation
| @@ -59,6 +59,7 @@ export default app // [!code --] | |||
| export default { // [!code ++] | |||
| port: 3000, // [!code ++] | |||
| fetch: app.fetch, // [!code ++] | |||
| request: app.request, // [!code ++] | |||
There was a problem hiding this comment.
When you say "this is not needed", does that mean you can use app.request without it?
Please tell me why it is not necessary.
Without this line, in my environment(bun 1.0.26, hono 4.0.1, 3.12.12) I get an error like this.
There was a problem hiding this comment.
I assume the following case where the port number is not changed.
const app = new Hono()
// ...
export default appThe exported application contains the request property.
There was a problem hiding this comment.
Yes, I understand that if "app" is exported, it has a request property. This proposal is to use "app.request" when "app" is not exported with port change. If you don't need that, then so be it. Thank you.
There was a problem hiding this comment.
Thank you for understanding. I want to keep it simple here, so can you please remove that line?
|
Thanks. I've commented. Check it. |
In the test when using bun, make the request method the same as the non-bun case.