feat: enable to skip overriding global Request and Response classes #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
usualoma
force-pushed
the
feat/skip-override-globals
branch
from
9ee301e to
5fefcfe
Compare
In node.js 20.12, supertest (or its dependencies) makes global.fetch unwritable and the test fails. This problem occurs only in the test code and should be handled in test/setup.ts.
usualoma
force-pushed
the
feat/skip-override-globals
branch
from
5fefcfe to
e2f4965
Compare
|
@yusukebe |
|
Hi @usualoma The test matter is not a problem. Great! I'll merge now. Thanks! |
nicolewhite
referenced
this pull request
in autoblocksai/cli
Apr 15, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@hono/node-server](https://togithub.com/honojs/node-server) | [`1.8.2` -> `1.10.0`](https://renovatebot.com/diffs/npm/@hono%2fnode-server/1.8.2/1.10.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>honojs/node-server (@​hono/node-server)</summary> ### [`v1.10.0`](https://togithub.com/honojs/node-server/releases/tag/v1.10.0) [Compare Source](https://togithub.com/honojs/node-server/compare/v1.9.1...v1.10.0) #### What's Changed - feat: enable to skip overriding global Request and Response classes by [@​usualoma](https://togithub.com/usualoma) in [https://github.com/honojs/node-server/pull/156](https://togithub.com/honojs/node-server/pull/156) - docs(readme): update by [@​yusukebe](https://togithub.com/yusukebe) in [https://github.com/honojs/node-server/pull/157](https://togithub.com/honojs/node-server/pull/157) **Full Changelog**: honojs/node-server@v1.9.1...v1.10.0 ### [`v1.9.1`](https://togithub.com/honojs/node-server/releases/tag/v1.9.1) [Compare Source](https://togithub.com/honojs/node-server/compare/v1.9.0...v1.9.1) #### What's Changed - fix(request): guess request protocol from incoming object by [@​usualoma](https://togithub.com/usualoma) in [https://github.com/honojs/node-server/pull/155](https://togithub.com/honojs/node-server/pull/155) **Full Changelog**: honojs/node-server@v1.9.0...v1.9.1 ### [`v1.9.0`](https://togithub.com/honojs/node-server/releases/tag/v1.9.0) [Compare Source](https://togithub.com/honojs/node-server/compare/v1.8.2...v1.9.0) #### What's Changed - feat: ignore response if already sent by raw level outgoing API. by [@​usualoma](https://togithub.com/usualoma) in [https://github.com/honojs/node-server/pull/153](https://togithub.com/honojs/node-server/pull/153) **Full Changelog**: honojs/node-server@v1.8.2...v1.9.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 4am on Monday" in timezone America/Chicago, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/autoblocksai/cli). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yOTMuMCIsInVwZGF0ZWRJblZlciI6IjM3LjI5My4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Nicole White <[email protected]>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.