-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ajv-validator): Add Ajv validator middleware #794
Conversation
🦋 Changeset detectedLatest commit: b08b4f4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
packages/ajv-validator/CHANGELOG.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is not needed. The Changesets will create it automatically.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you use Vitest instead of Jest? You can refer to the hello
middleware
packages/ajv-validator/package.json
Outdated
], | ||
"scripts": { | ||
"test": "jest", | ||
"build:cjs": "tsc -p tsconfig.cjs.json", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you use tsup
for the build instead of tsc
? See the hello
middleware.
Hi @ikhvost Thank you for the PR. I've left some comments. Check them out. |
3455251
to
88ff60e
Compare
88ff60e
to
b08b4f4
Compare
Hi, @yusukebe. I’ve incorporated all your suggestions; please review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thanks! I'll merge this now and release it. |
Hello,
I'd like to contribute an Ajv validator middleware for Hono.
The implementation is primarily based on the existing Zod validator middleware, with minimal changes to accommodate Ajv's API. I've also included test cases similar to those used for the TypeBox and Zod validators.