Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ajv-validator): Add Ajv validator middleware #794

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

ikhvost
Copy link
Contributor

@ikhvost ikhvost commented Oct 24, 2024

Hello,

I'd like to contribute an Ajv validator middleware for Hono.

The implementation is primarily based on the existing Zod validator middleware, with minimal changes to accommodate Ajv's API. I've also included test cases similar to those used for the TypeBox and Zod validators.

Copy link

changeset-bot bot commented Oct 24, 2024

🦋 Changeset detected

Latest commit: b08b4f4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hono/ajv-validator Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is not needed. The Changesets will create it automatically.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you use Vitest instead of Jest? You can refer to the hello middleware

],
"scripts": {
"test": "jest",
"build:cjs": "tsc -p tsconfig.cjs.json",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you use tsup for the build instead of tsc? See the hello middleware.

@yusukebe
Copy link
Member

yusukebe commented Nov 14, 2024

Hi @ikhvost

Thank you for the PR. I've left some comments. Check them out.

@ikhvost ikhvost force-pushed the feat/ajv-validator-middleware branch from 3455251 to 88ff60e Compare November 14, 2024 18:20
@ikhvost ikhvost force-pushed the feat/ajv-validator-middleware branch from 88ff60e to b08b4f4 Compare November 14, 2024 18:22
@ikhvost
Copy link
Contributor Author

ikhvost commented Nov 14, 2024

Hi, @yusukebe. I’ve incorporated all your suggestions; please review.

@ikhvost ikhvost requested a review from yusukebe November 14, 2024 18:23
Copy link
Member

@yusukebe yusukebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yusukebe
Copy link
Member

@ikhvost

Thanks! I'll merge this now and release it.

@yusukebe yusukebe merged commit c9f63de into honojs:main Nov 14, 2024
1 check passed
@github-actions github-actions bot mentioned this pull request Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants