Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(auth-js): remove config.basePath #752

Merged
merged 3 commits into from
Oct 5, 2024
Merged

Conversation

kodermax
Copy link
Contributor

@kodermax kodermax commented Sep 26, 2024

This pull request aims to remove the warning message: [auth][warn][env-url-basepath-redundant]. For more information, please see: https://warnings.authjs.dev#env-url-basepath-redundant.

Copy link

changeset-bot bot commented Sep 26, 2024

⚠️ No Changeset found

Latest commit: e3e3ed9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@yusukebe yusukebe changed the title remove config.basePath fix(auth-js): remove config.basePath Oct 4, 2024
@yusukebe
Copy link
Member

yusukebe commented Oct 4, 2024

Hi @kodermax

Sorry for the late response. The CI is failing. Any thought?

….35.3 for latest features and bug fixes

✅ (index.test.ts): add basePath to config for consistency in authentication tests
♻️ (index.test.ts): correct code style inconsistencies for better readability and maintainability
@kodermax
Copy link
Contributor Author

kodermax commented Oct 4, 2024

Hi @yusukebe. That was fixed.

Copy link
Member

@yusukebe yusukebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yusukebe
Copy link
Member

yusukebe commented Oct 5, 2024

@kodermax

Thanks. I'll merge this and release a new version now.

@yusukebe yusukebe merged commit 3d78fa4 into honojs:main Oct 5, 2024
1 check passed
@divyam234
Copy link
Contributor

@yusukebe Fix was not released as @kodermax didn't create changeset in this pr

@yusukebe
Copy link
Member

yusukebe commented Oct 7, 2024

@divyam234 Ooops. Will release it.

@yusukebe
Copy link
Member

yusukebe commented Oct 7, 2024

Hey. I've released it as 1.0.11. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants