Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: swaggerUI middleware option's required property #329

Merged
merged 2 commits into from
Dec 29, 2023

Conversation

sor4chi
Copy link
Contributor

@sor4chi sor4chi commented Dec 28, 2023

For now, this configuration could be accepted without type-error.
スクリーンショット 2023-12-29 0 13 45

But, this configuration output this broken html.
スクリーンショット 2023-12-29 0 15 00

So, I think we have to support this with type.

Copy link

changeset-bot bot commented Dec 28, 2023

🦋 Changeset detected

Latest commit: ad76245

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hono/swagger-ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@sor4chi sor4chi marked this pull request as draft December 28, 2023 14:56
@sor4chi sor4chi changed the title feat: make swaggerUI middleware option optional fix: swaggerUI middleware option's required property Dec 28, 2023
@sor4chi sor4chi marked this pull request as ready for review December 28, 2023 15:13
@yusukebe
Copy link
Member

LGTM!

@yusukebe yusukebe merged commit 5b17228 into honojs:main Dec 29, 2023
1 check passed
@github-actions github-actions bot mentioned this pull request Dec 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants