fix: add "key" attribute to suppress react "key" warnings #238
+75
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To suppress react key warnings in SSR.
To suppress react key warnings in runtime.
|
I am investigating the failure of the test... |
bcb8fdcWe are using |
|
@yusukebe |
|
Hi @usualoma These commits make sense. Looks good. I'll merge and release a new version. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
b953beb
As @yusukebe pointed out in #233 (comment),
templateelements are written out as arrays, but without the key attribute, which caused a warning, has been fixed.be543f3
There was no key attribute left in the content of the template element, which was exported by SSR, but when the element was restored by creatingElement on the client side, a warning was displayed due to the absence of the key attribute.
It may seem strange to add the key attribute with a sequential number, but these elements are not overwritten after rendering by the client, so there is no problem if the warning is avoided by adding a sequential number.