Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hono-base): don't use Symbol for COMPOSED_HANDLER #3773

Merged
merged 1 commit into from
Dec 28, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions src/hono-base.ts
Original file line number Diff line number Diff line change
Expand Up @@ -26,13 +26,9 @@ import type {
RouterRoute,
Schema,
} from './types'
import { COMPOSED_HANDLER } from './utils/constants'
import { getPath, getPathNoStrict, mergePath } from './utils/url'

/**
* Symbol used to mark a composed handler.
*/
export const COMPOSED_HANDLER = Symbol('composedHandler')

const notFoundHandler = (c: Context) => {
return c.text('404 Not Found', 404)
}
Expand Down
4 changes: 4 additions & 0 deletions src/utils/constants.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
/**
* Constant used to mark a composed handler.
*/
export const COMPOSED_HANDLER = '__COMPOSED_HANDLER'
2 changes: 1 addition & 1 deletion src/utils/handler.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
* Handler utility.
*/

import { COMPOSED_HANDLER } from '../hono-base'
import { COMPOSED_HANDLER } from './constants'

export const isMiddleware = (handler: Function) => handler.length > 1
export const findTargetHandler = (handler: Function): Function => {
Expand Down
Loading