Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: assign projectName after target is defined #57

Merged
merged 1 commit into from
Jul 6, 2024

Conversation

MathurAditya724
Copy link
Contributor

Closes #56

Now the projectName is getting assigned after target, so . value can be assigned basename.

Copy link
Member

@yusukebe yusukebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yusukebe
Copy link
Member

yusukebe commented Jul 6, 2024

Hi @MathurAditya724

This is a good fix. Thanks!

@yusukebe yusukebe merged commit dd656f7 into honojs:main Jul 6, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: dir basename is not getting used
2 participants