Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Reduce build size #49

Merged
merged 1 commit into from
Jun 20, 2024
Merged

perf: Reduce build size #49

merged 1 commit into from
Jun 20, 2024

Conversation

goisaki
Copy link
Contributor

@goisaki goisaki commented Jun 17, 2024

This PR will reduce the build size and the time it takes to run create-hono.

Changes

@goisaki goisaki marked this pull request as draft June 17, 2024 12:29
@yusukebe
Copy link
Member

Hey @goisaki !

This will be a good improvement. Is this ready for review?

@yusukebe
Copy link
Member

@goisaki

First, let's go with only minifying change. Changing libraries may cause problems since this project has not been tested well.

@goisaki
Copy link
Contributor Author

goisaki commented Jun 19, 2024

Hi @yusukebe
I understand.

@goisaki goisaki marked this pull request as ready for review June 19, 2024 09:47
@goisaki
Copy link
Contributor Author

goisaki commented Jun 19, 2024

@yusukebe Ready to go!

@yusukebe yusukebe changed the title feat: Reduce build size perf: Reduce build size Jun 20, 2024
@yusukebe
Copy link
Member

@goisaki

Okay! This is not a new feature but a performance issue. So, I labeled it perf and will release it as a patch. Thanks!

@yusukebe yusukebe merged commit 24e3e88 into honojs:main Jun 20, 2024
4 checks passed
@goisaki goisaki deleted the feat/reduce-size branch August 18, 2024 02:02
@goisaki goisaki mentioned this pull request Aug 19, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants