RFC: Add support for 3- and 4-line date+time display on vertical panels #1854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On narrow vertical panels (and not-so-narrow ones -- at least on my system, "narrow" seems to include the default 48px-wide panel), the date is not displayed for lack of space. This patch shows the date on those narrow panels by splitting the date over multiple lines ("Mar\n11", for example) if necessary.
This results in a behavior change that not everyone might like, so I suppose someone might want it gated behind a config option -- I didn't have time to figure that out. (Also, I'd personally prefer to get rid of the | and : separators in the date/time in vertical panels -- that's basically how it looks on ChromeOS, and that works fine and is less cluttered -- but elected to make a minimal change with this patch.)