Code cleanup #1562
Open
Code cleanup #1562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rastersoft
force-pushed
the
code_cleanup
branch
from
f414909
to
591fa3f
Compare
The current enable() and disable() methods in the panelManager class do receive a 'reset' parameter to allow to "reset" and recreate the panels without disconnecting and connecting again signals and doing the whole disable-and-enable process. This MR moves the common part into their own functions, and thus removing the parameter and making the code simpler.
rastersoft
force-pushed
the
code_cleanup
branch
from
591fa3f
to
c2d4302
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current enable() and disable() methods in the panelManager class do receive a 'reset' parameter to allow to "reset" and recreate the panels without disconnecting and connecting again signals and doing the whole disable-and-enable process.
This MR moves the common part into their own functions, and thus removing the parameter and making the code simpler.