-
-
Notifications
You must be signed in to change notification settings - Fork 30.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align Switcher cover platform with changes from light platform #130094
Conversation
Hey there @thecode, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
I will look at it tomorrow, please avoid using generic PR title such as "Switcher small fix for cover", these are shown in release notes later and should be more descriptive. The comment in the PR description is better. I edited the PR title to match it (look at it for the next PRs) Also this is not a bugfix as it doesn't fix anything for the user? does it? is there something broken in the cover platform now? |
Hmm yeah just alignment to the code. should work the same. How would you tag this PR then? |
Update: changed to code quality improvement |
Thanks @YogevBokobza |
Proposed change
Just alignment for covers as did for lights
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: