Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align Switcher cover platform with changes from light platform #130094

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

YogevBokobza
Copy link
Contributor

@YogevBokobza YogevBokobza commented Nov 7, 2024

Proposed change

Just alignment for covers as did for lights

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Nov 7, 2024

Hey there @thecode, mind taking a look at this pull request as it has been labeled with an integration (switcher_kis) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of switcher_kis can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign switcher_kis Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@thecode
Copy link
Member

thecode commented Nov 8, 2024

I will look at it tomorrow, please avoid using generic PR title such as "Switcher small fix for cover", these are shown in release notes later and should be more descriptive.

The comment in the PR description is better. I edited the PR title to match it (look at it for the next PRs)

Also this is not a bugfix as it doesn't fix anything for the user? does it? is there something broken in the cover platform now?

@thecode thecode changed the title Switcher small fix for cover Align Switcher cover platform with changes from light platform Nov 8, 2024
@YogevBokobza
Copy link
Contributor Author

I will look at it tomorrow, please avoid using generic PR title such as "Switcher small fix for cover", these are shown in release notes later and should be more descriptive.

The comment in the PR description is better. I edited the PR title to match it (look at it for the next PRs)

Also this is not a bugfix as it doesn't fix anything for the user? does it? is there something broken in the cover platform now?

Hmm yeah just alignment to the code. should work the same. How would you tag this PR then?

@YogevBokobza
Copy link
Contributor Author

I will look at it tomorrow, please avoid using generic PR title such as "Switcher small fix for cover", these are shown in release notes later and should be more descriptive.
The comment in the PR description is better. I edited the PR title to match it (look at it for the next PRs)
Also this is not a bugfix as it doesn't fix anything for the user? does it? is there something broken in the cover platform now?

Hmm yeah just alignment to the code. should work the same. How would you tag this PR then?

Update: changed to code quality improvement

@thecode
Copy link
Member

thecode commented Nov 8, 2024

Hmm yeah just alignment to the code. should work the same. How would you tag this PR then?

Code quality, make sure to tick only what is valid, there are no tests in this PR (as should be since it doesn't change the operation only make the code neater)

image

@thecode
Copy link
Member

thecode commented Nov 8, 2024

Thanks @YogevBokobza

@thecode thecode merged commit 0d19e85 into home-assistant:dev Nov 8, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants