Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for MW/GW/TW and GWh/TWh #130089

Draft
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

jschlyter
Copy link
Contributor

@jschlyter jschlyter commented Nov 7, 2024

Proposed change

Add support for larger energy and power units:

  • Power: MW/GW/TW
  • Energy: GWh/TWh

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant home-assistant bot added cla-signed core small-pr PRs with less than 30 lines. labels Nov 7, 2024
homeassistant/const.py Outdated Show resolved Hide resolved
homeassistant/const.py Outdated Show resolved Hide resolved
@jschlyter jschlyter marked this pull request as ready for review November 8, 2024 05:28
@jschlyter jschlyter requested a review from a team as a code owner November 8, 2024 05:28
Copy link
Contributor

@epenet epenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is failing, please adjust accordingly.
You also need to open a PR on docs repo https://github.com/home-assistant/home-assistant.io and on the dev-docs repo https://github.com/home-assistant/developers.home-assistant

@home-assistant
Copy link

home-assistant bot commented Nov 8, 2024

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft November 8, 2024 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants