-
-
Notifications
You must be signed in to change notification settings - Fork 30.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add EveCluster ValvePosition Attribute #125809
Add EveCluster ValvePosition Attribute #125809
Conversation
Hey there @home-assistant/matter, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Follow up ValvePosition attribute of EveCluster Cluster #880. |
Bump to python-matter-server==6.5.1
Fixture for a Eve Thermo node
ruff-format
Change device_class to ValveDeviceClass.WATER,
48c7977
to
6d704d7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved from my pov but can use an extra pair of eyes as I finished the PR
Thanks Marcel |
Breaking change
Proposed change
Add EveCluster ValvePosition Attribute for Eve Thermo device.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests:
Local testing