-
-
Notifications
You must be signed in to change notification settings - Fork 28.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use async_setup_recorder_instance fixture in recorder v32_migration tests #121081
Conversation
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
@@ -221,7 +221,9 @@ def _get_events_index_names(): | |||
|
|||
|
|||
async def test_migrate_can_resume_entity_id_post_migration( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a bit surprised this test is passing without enabling the migration functions, that was needed to make the previous test in this file pass
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see the schema gets updated WARNING:homeassistant.components.recorder.migration:Database is about to upgrade from schema version: 32 to: 43
All the runtime migrations are skipped because they are patched out.
Than it starts again, the run time migrations run, and the ix_states_entity_id_last_updated_ts index is removed after the FK removal for mysql & postgresql, and table rebuild for sqlite
4269189
to
0c8d9ba
Compare
Proposed change
Use async_setup_recorder_instance fixture in recorder v32_migration tests
This makes the tests much more robust when failing
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: