-
-
Notifications
You must be signed in to change notification settings - Fork 28.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use fixtures in deCONZ alarm control panel tests #120967
Use fixtures in deCONZ alarm control panel tests #120967
Conversation
aioclient_mock: AiohttpClientMocker, | ||
config_entry_setup: ConfigEntry, | ||
mock_put_request: Callable[[str, str], AiohttpClientMocker], | ||
mock_deconz_websocket, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If order doesn't matter here you could use @pytest.mark.usefixtures
for mock_deconz_websocket
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually it looks like you call it, so would be nice to type it, but it looks like it only uses kwargs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My plan is to type it in its own PR to keep these other PRs to keep them as small as possible
Thanks @bdraco 🎉 |
Breaking change
Proposed change
SSIA
Related to #120863, #120936, #120938, #120943, #120944, #120947, #120948, #120953, #120954, #120966
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: