Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Matter update entities for devices with OTA requestor #120304

Merged
merged 10 commits into from
Jul 23, 2024

Conversation

agners
Copy link
Member

@agners agners commented Jun 24, 2024

Breaking change

Proposed change

Matter devices which support the OTA requestor cluster can receive updates from a OTA provider. The Home Assistant Python Matter Server implements such an OTA provider now.

Add update entities for devices which support the OTA requestor cluster and check for available updates. Allow the user to update the firmware. The update progress will be read directly from the devices' OTA requestor cluster.

Related Python Matter Server PR: home-assistant-libs/python-matter-server#709

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @home-assistant/matter, mind taking a look at this pull request as it has been labeled with an integration (matter) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of matter can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign matter Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@agners agners force-pushed the matter-update-entity branch 2 times, most recently from 045a999 to 3901a0a Compare July 19, 2024 12:51
@agners agners marked this pull request as ready for review July 19, 2024 13:00
@agners agners requested a review from a team as a code owner July 19, 2024 13:00
Copy link
Member

@marcelveldt marcelveldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From a Matter POV this one is approved - I'll leave a final approval to Erik as member of the core team.

One note is that we agreed to show the extra warning, for which an architecture discussion is created and an implementation (at core level) needs to be implemented.

If we agree to merge this now, we should also make sure to fix that dialog before the release of HA 2024.8

agners and others added 9 commits July 23, 2024 13:59
Matter devices which support the OTA requestor cluster can receive
updates from a OTA provider. The Home Assistant Python Matter Server
implements such an OTA provider now.

Add update entities for devices which support the OTA requestor cluster
and check for available updates. Allow the user to update the firmware.
The update progress will be read directly from the devices' OTA
requestor cluster.
This includes models and commands required for device firmware updates.
Matter entities don't enable polling any longer. Enable polling for
update entities by default.
Copy link
Contributor

@emontnemery emontnemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

homeassistant/components/matter/update.py Show resolved Hide resolved
@agners agners merged commit 07b2a75 into home-assistant:dev Jul 23, 2024
40 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 24, 2024
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR was merged with only 85% test coverage. Please add more tests.

tests/components/matter/test_update.py Show resolved Hide resolved
@agners agners deleted the matter-update-entity branch July 25, 2024 06:04
@agners
Copy link
Member Author

agners commented Jul 25, 2024

This PR was merged with only 85% test coverage. Please add more tests.

PR #122575 adds more tests.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants