Use StarScream branch which prevents multiple URLSession creation #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robbiet480
approved these changes
Mar 27, 2024
|
This doesn't block the merge but probably best to move the Starscream fork into the HA GitHub org |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #57 +/- ##
=======================================
Coverage 99.87% 99.87%
=======================================
Files 50 50
Lines 1595 1598 +3
=======================================
+ Hits 1593 1596 +3
Misses 2 2 ☔ View full report in Codecov by Sentry. |
bgoncal
commented
Mar 27, 2024
| @@ -124,6 +124,8 @@ internal class HAResponseControllerImpl: HAResponseController { | |||
| case let .error(error): | |||
| HAGlobal.log(.error, "Error: \(String(describing: error))") | |||
| phase = .disconnected(error: error, forReset: false) | |||
| case .peerClosed: | |||
| HAGlobal.log(.info, "Peer closed") | |||
There was a problem hiding this comment.
Should I move phase to disconnected? (This new case comes from upgrading starscream from 4.0.4 to 4.0.6)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StarScream seems to be creating one URLSession per request, which is against Apple's recommendation of reusing existing URLSession.
Besides that apparently this also has a consequence of in a "retry loop" in Home Assistant App, user may never be able to reconnect due to error
POSIXErrorCode(rawValue: 28): No space left on device)which comes from the limit of URLSession's allowed.Related issue: home-assistant/iOS#2638
My PR to StarScream: daltoniam/Starscream#1011