-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update label on interview #909
Conversation
When triggering an interview update the Fabric label on the device as well. This allows users to update the label by a simple re-interview.
Hmm, not sure if I like this side effect. It feels a tiny bit strange to do this in the client library from a purist perspective. |
Yeah similar, it feels a bit "wrong" in a way. But then, I felt reinterview is soemthing which doesn't happen often. Currently it would happen in three cases: We could also change things so that only in case a) we actually set the label (on a manual interview). What do you think?
Well, I intended more that the user has a way to actually update the label currently (via reinterview command). Setting the labels on all existing commissioned devices is not the aim here. |
Yes, lets only do it in case of a) |
Hi, do I understand it right, that we now should see a label instead of 4939, after re-interviewing Matter devices? If so, it doesn’t work in my case. I successfully re-interviewed some of my devices in Home Assistant, but the fabric label in Apple Home is still 4939: The name of my Home Assistant instance is ‘Home Assistant‘: My understanding is that ‘Home Assistant‘ should be the new fabric label in Apple Home. Is this right? Everything is up-to-date: Core 2024.10.1 Thanks Hoppel |
What Apple prints under Connected Services are two things: The vendor and the fabric label. The vendor name (printed in the larger font) comes from the DCL and recently got set to "Nabu Casa" and then we changed it to "Home Assistant (Nabu Casa)" (see the Nabu Casa 4939 DCL entry). In my Apple Home it currently shows as "Nabu Casa", but I expect that Apple will fetch the updated vendor information over time. The Fabric label will be set on commissioning or interview. It will be set to the Home Assistant instance name (as set in Settings > System-> General, also known as location name). The PR on Core side got merged after the last release, so it will only be part of Home Assistant 2024.11.0 (or current dev versions). |
@agners Great, thanks for the detailed information. Can’t wait for the day when Home Assistant got certified. 😃 Thanks again for all the work the Home Assistant Team investigates into Matter, especially @marcelveldt and you. Regards Hoppel |
When triggering an interview update the Fabric label on the device as well. This allows users to update the label by a simple re-interview.