Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update label on interview #909

Merged
merged 2 commits into from
Oct 1, 2024
Merged

Update label on interview #909

merged 2 commits into from
Oct 1, 2024

Conversation

agners
Copy link
Collaborator

@agners agners commented Oct 1, 2024

When triggering an interview update the Fabric label on the device as well. This allows users to update the label by a simple re-interview.

When triggering an interview update the Fabric label on the device as
well. This allows users to update the label by a simple re-interview.
@agners agners added the new-feature New feature or request label Oct 1, 2024
@marcelveldt
Copy link
Contributor

Hmm, not sure if I like this side effect. It feels a tiny bit strange to do this in the client library from a purist perspective.
At the same time it does make sense to do this in one sweep. Maybe we should perform this action from HA ?

@agners
Copy link
Collaborator Author

agners commented Oct 1, 2024

Hmm, not sure if I like this side effect. It feels a tiny bit strange to do this in the client library from a purist perspective.

Yeah similar, it feels a bit "wrong" in a way. But then, I felt reinterview is soemthing which doesn't happen often.

Currently it would happen in three cases:
a) When the user asks for a reinterview (the case I aim for)
b) When there was a software update (which triggers a reinterview)
c) When there was a interview schema change

We could also change things so that only in case a) we actually set the label (on a manual interview). What do you think?

At the same time it does make sense to do this in one sweep. Maybe we should perform this action from HA ?

Well, I intended more that the user has a way to actually update the label currently (via reinterview command).

Setting the labels on all existing commissioned devices is not the aim here.

@marcelveldt
Copy link
Contributor

marcelveldt commented Oct 1, 2024

Yes, lets only do it in case of a)
We can then argue to do the implementation server side or client side.
Let's keep it simple now and do it server side.

@agners agners merged commit dd50c46 into main Oct 1, 2024
4 checks passed
@agners agners deleted the update-label-on-interview branch October 1, 2024 19:25
@hoppel118
Copy link

Hi,

do I understand it right, that we now should see a label instead of 4939, after re-interviewing Matter devices?

If so, it doesn’t work in my case. I successfully re-interviewed some of my devices in Home Assistant, but the fabric label in Apple Home is still 4939:

IMG_0641
IMG_0640

The name of my Home Assistant instance is ‘Home Assistant‘:

IMG_0642

My understanding is that ‘Home Assistant‘ should be the new fabric label in Apple Home. Is this right?

Everything is up-to-date:

Core 2024.10.1
Supervisor 2024.10.0
Operating System 13.1
Frontend 20241002.2
HA Matter Server 6.6.0

Thanks Hoppel

@agners
Copy link
Collaborator Author

agners commented Oct 8, 2024

My understanding is that ‘Home Assistant‘ should be the new fabric label in Apple Home. Is this right?

What Apple prints under Connected Services are two things: The vendor and the fabric label. The vendor name (printed in the larger font) comes from the DCL and recently got set to "Nabu Casa" and then we changed it to "Home Assistant (Nabu Casa)" (see the Nabu Casa 4939 DCL entry). In my Apple Home it currently shows as "Nabu Casa", but I expect that Apple will fetch the updated vendor information over time.

The Fabric label will be set on commissioning or interview. It will be set to the Home Assistant instance name (as set in Settings > System-> General, also known as location name). The PR on Core side got merged after the last release, so it will only be part of Home Assistant 2024.11.0 (or current dev versions).

@hoppel118
Copy link

@agners Great, thanks for the detailed information.

Can’t wait for the day when Home Assistant got certified. 😃

Thanks again for all the work the Home Assistant Team investigates into Matter, especially @marcelveldt and you.

Regards Hoppel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants