Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change subscription floor to 1 second to prevent flooding #891

Merged
merged 2 commits into from
Sep 19, 2024
Merged

Change subscription floor to 1 second to prevent flooding #891

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
05a3542
Chgange subscription floor to 2 seconds to prevent flooding during tr…
marcelveldt Sep 18, 2024
3a06c65
use 1 second
marcelveldt Sep 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions matter_server/server/device_controller.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,7 @@
DATA_KEY_LAST_NODE_ID = "last_node_id"

LOGGER = logging.getLogger(__name__)
NODE_SUBSCRIPTION_FLOOR = 1
NODE_SUBSCRIPTION_CEILING_WIFI = 60
NODE_SUBSCRIPTION_CEILING_THREAD = 60
NODE_SUBSCRIPTION_CEILING_BATTERY_POWERED = 600
Expand Down Expand Up @@ -1221,7 +1222,6 @@ def resubscription_succeeded(
self.server.signal_event(EventType.NODE_UPDATED, node)

node_logger.info("Setting up attributes and events subscription.")
interval_floor = 0
# determine subscription ceiling based on routing role
# Endpoint 0, ThreadNetworkDiagnostics Cluster, routingRole attribute
# for WiFi devices, this cluster doesn't exist.
Expand All @@ -1244,7 +1244,7 @@ def resubscription_succeeded(
[()],
events=[("*", 1)],
return_cluster_objects=False,
report_interval=(interval_floor, interval_ceiling),
report_interval=(NODE_SUBSCRIPTION_FLOOR, interval_ceiling),
auto_resubscribe=True,
)
)
Expand Down