Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup: Lower "Activity on mDNS" message #883

Merged
merged 2 commits into from
Sep 12, 2024
Merged

Cleanup: Lower "Activity on mDNS" message #883

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d74782c
Lower "Activity on mDNS" message
agners Sep 12, 2024
9c7c983
Update matter_server/server/device_controller.py
agners Sep 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion matter_server/server/device_controller.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1481,7 +1481,13 @@ def _on_mdns_operational_node_state(
self._setup_node_create_task(node_id)
elif state_change == ServiceStateChange.Added:
# Trigger node re-subscriptions when mDNS entry got added
node_logger.info("Activity on mDNS, trigger resubscribe")
# Note: Users seem to get such mDNS messages fairly regularly, and often
# the subscription to the device is healthy and fine. This is not a problem
# since trigger_resubscribe_if_scheduled won't do anything in that case
# (no resubscribe is scheduled).
# But this does speedup the resubscription process in case the subscription
# is already in resubscribe mode.
node_logger.debug("Activity on mDNS, trigger resubscribe if scheduled")
asyncio.create_task(
self._chip_device_controller.trigger_resubscribe_if_scheduled(
node_id, "mDNS state change detected"
Expand Down