Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shutdown subscription after exactly 30 minutes #876

Merged
merged 3 commits into from
Sep 4, 2024
Merged

Shutdown subscription after exactly 30 minutes #876

merged 3 commits into from
Sep 4, 2024

Commits on Sep 4, 2024

  1. Shutdown subscription after exactly 30 minutes 

    Instead of relying on the progressively growing and random resubscribe
interval simply check the time since the first re-subscription attempt.

The resubscribe interval is chosen at random, and even in the terminal
state, a resubscription potentially happens below 30 minutes (in the
final progression the resubscription time is chosen at random between
27 and 92 minutes). This means that in theory we shutdown the
subscription much later than actually intended.
    @agners
    agners committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    78a3706 View commit details
    Browse the repository at this point in the history

  2. Rename _last_subscription_attempt to _resubscription_attempt

    @agners
    agners committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    b3c318c View commit details
    Browse the repository at this point in the history

  3. Update matter_server/server/device_controller.py 

    Co-authored-by: Marcel van der Veldt <[email protected]>
    @agners @marcelveldt
    agners and marcelveldt committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    5940463 View commit details
    Browse the repository at this point in the history