Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry subscription setup if necessary #873

Merged
merged 7 commits into from
Sep 4, 2024
Merged

Commits on Sep 3, 2024

  1. Retry subscription setup if necessary

    With the update of the Matter SDK wheels to 2024.7.1 (#809) the SDK
    no longer auto-resubscribes when the read of the subscription fails
    (see project-chip/connectedhomeip#34370).
    The Server had a comment that it relies on mDNS rediscovery to
    re-establish the subscription. But this is not always the case. This
    change adds a retry mechanism to the subscription setup for a fixed
    period of time after seeing it via mDNS.
    
    Additionally, it avoids recreating the subscription if the liveness
    timeout did not occur yet. This puts more trust into the SDK handling
    the subscriptions.
    agners committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    4902d4a View commit details
    Browse the repository at this point in the history
  2. Update matter_server/server/device_controller.py

    Co-authored-by: Marcel van der Veldt <[email protected]>
    agners and marcelveldt authored Sep 3, 2024
    Configuration menu
    Copy the full SHA
    aa5622e View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2024

  1. Create task to setup node

    Use a task in all cases when we (re-)setup the node. Use the task to
    also make sure that only a single setup is running at a time. And
    finally it allows us to abort any currently running setup task at the
    end.
    agners committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    3b239a6 View commit details
    Browse the repository at this point in the history
  2. Improve logging

    agners committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    66faa0b View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    69a20c4 View commit details
    Browse the repository at this point in the history
  4. Add comment

    agners committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    2ab5604 View commit details
    Browse the repository at this point in the history
  5. Rename _setup_tasks_with_retry and _setup_tasks

    We'll have to implement retry on our end, so use this as the new normal
    naming.
    agners committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    cad00c4 View commit details
    Browse the repository at this point in the history