Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump ruff from 0.5.7 to 0.6.2 #864

Merged
merged 2 commits into from
Aug 29, 2024
Merged

Bump ruff from 0.5.7 to 0.6.2 #864

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7772ce2
Bump ruff from 0.5.7 to 0.6.2
dependabot[bot] Aug 26, 2024
71937ef
Disable timeout linter warning
agners Aug 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion matter_server/client/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ async def set_thread_operational_dataset(self, dataset: str) -> None:
async def open_commissioning_window(
self,
node_id: int,
timeout: int = 300,
timeout: int = 300, # noqa: ASYNC109 timeout parameter required for native timeout
agners marked this conversation as resolved.
Show resolved Hide resolved
iteration: int = 1000,
option: int = 1,
discriminator: Optional[int] = None,
Expand Down
8 changes: 7 additions & 1 deletion matter_server/server/device_controller.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -443,7 +443,7 @@ async def set_thread_operational_dataset(self, dataset: str) -> None:
async def open_commissioning_window(
self,
node_id: int,
timeout: int = 300,
timeout: int = 300, # noqa: ASYNC109 timeout parameter required for native timeout
iteration: int = 1000,
option: int = ChipDeviceController.CommissioningWindowPasscode.kTokenWithRandomPin,
discriminator: int | None = None,
Expand Down Expand Up @@ -677,6 +677,12 @@ async def read_attribute(
for attr_path in attribute_paths
}

LOGGER.debug(
"read_attribute called for node %s on path(s): %s - fabric_filtered: %s",
node_id,
str(attribute_paths),
fabric_filtered,
)
# parse text based attribute paths into the SDK Attribute Path objects
attributes: list[Attribute.AttributePath] = []
for attr_path in attribute_paths:
Expand Down
2 changes: 1 addition & 1 deletion matter_server/server/helpers/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
PLATFORM_MAC = platform.system() == "Darwin"


async def ping_ip(ip_address: str, timeout: int = 2, attempts: int = 1) -> bool:
async def ping_ip(ip_address: str, timeout: int = 2, attempts: int = 1) -> bool: # noqa: ASYNC109 timeout parameter required for native ping timeout
"""Ping given (IPv4 or IPv6) IP-address."""
is_ipv6 = ":" in ip_address
if is_ipv6 and PLATFORM_MAC:
Expand Down
2 changes: 1 addition & 1 deletion matter_server/server/sdk.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,7 @@ async def unpair_device(self, node_id: int) -> PyChipError:
async def open_commissioning_window(
self,
node_id: int,
timeout: int,
timeout: int, # noqa: ASYNC109 timeout parameter required for native timeout
iteration: int,
discriminator: int,
option: ChipDeviceController.CommissioningWindowPasscode,
Expand Down