Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some small fixes for the client #339

Merged
merged 5 commits into from
Jun 28, 2023
Merged

Some small fixes for the client #339

merged 5 commits into from
Jun 28, 2023

Conversation

marcelveldt
Copy link
Contributor

@marcelveldt marcelveldt commented Jun 28, 2023 •
edited
Loading

Some small fixes/improvements based on feedback last couple of days:

  • Require schema version 4 for the call to "subscribe_attribute"
  • Rename "subscribe" to "subscribe_events" to make its purpose more clear [BREAKING]
  • Raise NodeNotExists instead of KeyError in get_node method if the node does not exist

MartinHjelmare
MartinHjelmare approved these changes Jun 28, 2023
View reviewed changes
Copy link
Contributor

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR description needs an update.

@MartinHjelmare MartinHjelmare added the breaking-change Breaking changes label Jun 28, 2023
@marcelveldt marcelveldt merged commit 4238166 into main Jun 28, 2023
@marcelveldt marcelveldt deleted the small-fixes branch June 28, 2023 09:07
@MartinHjelmare MartinHjelmare mentioned this pull request Jun 29, 2023
Merged
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

Assignees
No one assigned
Labels
breaking-change Breaking changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marcelveldt @MartinHjelmare