Edge case defect when importing the first test node into dashboard (#763

)
home-assistant-libs · Jun 18, 2024 · 950663f · 950663f
1 parent ffaf1f7
commit 950663f
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/matter_server/server/device_controller.py b/matter_server/server/device_controller.py
@@ -865,7 +865,12 @@ async def import_test_node(self, dump: str) -> None:
         else:
             dump_nodes = dump_data["data"]["server"]["nodes"]
         # node ids > 900000 are reserved for test nodes
-        next_test_node_id = max(*(x for x in self._nodes), TEST_NODE_START) + 1
+        if self._nodes:
+            next_test_node_id = max(*(x for x in self._nodes), TEST_NODE_START) + 1
+        else:
+            # an empty self._nodes dict evaluates to false so we set the first
+            # test node id to TEST_NODE_START
+            next_test_node_id = TEST_NODE_START
         for node_dict in dump_nodes:
             node = dataclass_from_dict(MatterNodeData, node_dict, strict=True)
             node.node_id = next_test_node_id