Skip to content

Commit

Permalink
Remove the workaround that is overriding the liveness timeout (#427)
Browse files Browse the repository at this point in the history
  • Loading branch information
marcelveldt authored Nov 4, 2023
1 parent 6a8fcb7 commit 32b654c
Showing 1 changed file with 0 additions and 14 deletions.
14 changes: 0 additions & 14 deletions matter_server/server/device_controller.py
Original file line number Diff line number Diff line change
Expand Up @@ -740,20 +740,6 @@ def resubscription_attempted(
if node.available:
node.available = False
self.server.signal_event(EventType.NODE_UPDATED, node)
if nextResubscribeIntervalMsec / 1000 > MAX_POLL_INTERVAL:
# workaround to handle devices that are unplugged
# from power for a longer period of time
# where the sdk is extending the poll timeout at every attempt
# until even 1,5 hours which is way too long.
# instead a device back alive should be detected using mDNS,
# which is not yet implemented in the core sdk.
# For now, we just override the timeout.
# NOTE 1: fix this once OperationalNodeDiscovery is available:
# https://github.com/project-chip/connectedhomeip/pull/26718
# https://github.com/project-chip/connectedhomeip/issues/29663
# NOTE 2: We could also just implement zeroconf/mdns ourselves
# to listen for the announcements.
sub.OverrideLivenessTimeoutMs(MAX_POLL_INTERVAL * 1000)

def resubscription_succeeded(
transaction: Attribute.SubscriptionTransaction,
Expand Down

0 comments on commit 32b654c

Please sign in to comment.