Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for logout from OAuth provider #6935

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

philippjfr
Copy link
Member

Until now we never logged the user out of the OAuth provider we simply cleared the cookies. This is "usually" the desirable behavior since often the OAuth provider is part of a larger SSO system and you don't want to log someone out of Google/GitHub/Gitlab/Azure/Okta when you're simply wanting to log out of the app. Here we make it possible to log the user out of Okta and make the logout endpoint configurable for the GenericLoginHandler.

  • Add tests
  • Update docs

Copy link

codecov bot commented Jun 24, 2024

Codecov Report

Attention: Patch coverage is 34.14634% with 27 lines in your changes missing coverage. Please review.

Project coverage is 81.51%. Comparing base (241b45e) to head (f990144).
Report is 332 commits behind head on main.

Files with missing lines Patch % Lines
panel/auth.py 34.14% 27 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6935      +/-   ##
==========================================
- Coverage   81.57%   81.51%   -0.06%     
==========================================
  Files         323      323              
  Lines       47509    47550      +41     
==========================================
+ Hits        38754    38762       +8     
- Misses       8755     8788      +33     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant