Skip to content
This repository has been archived by the owner on Sep 20, 2021. It is now read-only.

Ci #45

Open
wants to merge 35 commits into
base: master
Choose a base branch
from
Open

Ci #45

wants to merge 35 commits into from

Conversation

Pierozi
Copy link
Member

@Pierozi Pierozi commented Dec 2, 2017

Sequel to #40

I've created this PR here instead of on @vonglasow repository because I'm facing strange behavior on Travis and prefer to let PR hook of the original repository to trigger Travis.

@ghost ghost assigned Pierozi Dec 2, 2017
@ghost ghost added the in progress label Dec 2, 2017
@coveralls
Copy link

coveralls commented Dec 2, 2017

Coverage Status

Changes Unknown when pulling 6252d0b on Pierozi:ci into ** on hoaproject:master**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 273e5a6 on Pierozi:ci into ** on hoaproject:master**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 9a5138d on Pierozi:ci into ** on hoaproject:master**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling b6ba8d3 on Pierozi:ci into ** on hoaproject:master**.

@coveralls
Copy link

coveralls commented Dec 3, 2017

Coverage Status

Changes Unknown when pulling 1be7b62 on Pierozi:ci into ** on hoaproject:master**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling b5aed28 on Pierozi:ci into ** on hoaproject:master**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling fe6b6af on Pierozi:ci into ** on hoaproject:master**.

@coveralls
Copy link

coveralls commented Dec 3, 2017

Coverage Status

Changes Unknown when pulling a1fa156 on Pierozi:ci into ** on hoaproject:master**.

@coveralls
Copy link

coveralls commented Dec 3, 2017

Coverage Status

Changes Unknown when pulling d753311 on Pierozi:ci into ** on hoaproject:master**.

@coveralls
Copy link

coveralls commented Dec 3, 2017

Coverage Status

Changes Unknown when pulling 89529bd on Pierozi:ci into ** on hoaproject:master**.

1 similar comment
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 89529bd on Pierozi:ci into ** on hoaproject:master**.

@Pierozi
Copy link
Member Author

Pierozi commented Dec 3, 2017

@vonglasow @Hywan test on travis is good now.
I've implemented 7.2 and discover a deprecated in Hoa\Realdom regarding each method.

Ustring.php Outdated
@@ -520,15 +520,15 @@ function (array $matches) {
);
}

$string = static::transcode($string, 'UTF-8', 'ASCII//IGNORE//TRANSLIT');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this change?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because the test fail like this, and I assumed that the behavior expected was to replace by ascii not ignore.

There is 1 failure:
~> Hoa\Ustring\Test\Unit\Ustring::case_to_ascii_no_transliterator_no_normalizer_try():
In file /home/pierozi/Project/github/pierozi/Ustring/Test/Unit/Ustring.php on line 953, mageekguy\atoum\asserters\phpString() failed: strings are not equal
-Expected
+Actual
@@ -1 +1 @@
-string(26) "Un ete brulant sur la cote"
+string(22) "Un t brlant sur la cte"

@Hywan
Copy link
Member

Hywan commented Dec 4, 2017

Excellent, thanks for the hard work!

@Hywan
Copy link
Member

Hywan commented Dec 27, 2017

I would like @vonglasow to review this PR, so that we can close #40, and progress on hoaproject/Central#36.

@vonglasow
Copy link
Member

It's ok for me 👍

@vonglasow vonglasow mentioned this pull request Dec 27, 2017
@Pierozi
Copy link
Member Author

Pierozi commented Feb 12, 2018

@Hywan have you a idea why we have this dependency issue since you merge master?

@Pierozi
Copy link
Member Author

Pierozi commented Feb 14, 2018

Like now the composer require dev dependencies, even if I change the stability to dev, the issue is now related to Hoa\Kitab who include hoa\exception as stable but are in conflict with Ustring where is declared as dev

@Hywan Should we update all to dev-master during the transition of php7.1?
and in this case update hoa\test to require Kitab as dev-master.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

Successfully merging this pull request may close these issues.

4 participants