Small fixes #324
Merged
Small fixes #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks once again :) |
williamdemeo
added a commit
to formalverification/milewski-ctfp-pdf
that referenced
this pull request
Nov 12, 2023
* Fix spacing around multiplication operator (hmemcpy#319) * Fix prettier check (hmemcpy#321) * Make spaces after functors consistent (hmemcpy#320) * nix: refactor Nix flake files (hmemcpy#323) * Use `\mathit` for multi-letter identifiers (hmemcpy#322) * Small fixes (hmemcpy#324) * fix CI problems Steps taken to address failing the ci prettier check: 1. Install `nodejs` (e.g., by adding `nodejs` to the `environment.systemPackages` section of `/etc/nixos/configuration.nix`). 2. Install `prettier` using the command `npm install --save-dev --save-exact prettier`. 3. Run `npx prettier . --check` and get something like the following output: ``` Checking formatting... [warn] package-lock.json [warn] package.json [warn] README.md [warn] Code style issues found in 3 files. Run Prettier to fix. ``` (The `package-lock.json` and `package.json` files are not relevant. They were added by nodejs; they're not part of our repo.) 4. Run the command `npx prettier README.md --check`. You should get something like `README.md 21ms`. Checking `git diff` confirms that the CI prettier check didn't like some of the formatting of `README.md` and running `npx prettier README.md --write` fixed the problem. * fix ci problem Steps to fix the `nix fmt` ci failure: 1. In the root directory of the repo, run `nix fmt . -- --check` and get the following output: ``` ./flake.nix 1 / 1 would have been reformatted error: fail on changes ``` 2. Run `nix fmt` and get the following output: ``` ./flake.nix 1 / 1 have been reformatted ``` Checking `git diff` confirms that the CI `nix fmt` check didn't like some of the formatting of `flake.nix` and running `nix fmt` fixed the problem. * fix prettier ci problem (again) Steps to fix ci problem: 1. Run ` nix run nixpkgs#nodePackages.prettier -- --check .` and get output like ``` Checking formatting... [warn] package-lock.json [warn] package.json [warn] README.md [warn] Code style issues found in 2 files. Run Prettier to fix. ``` 2. Run `npx prettier README.md --write` and get output like ``` README.md 33ms ``` Checking `git diff` confirms that the CI prettier check didn't like some of the formatting of `README.md` and running `npx prettier README.md --write` fixed the problem. --------- Co-authored-by: EFanZh <[email protected]> Co-authored-by: Pol Dellaiera <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains two fixes:
\code{c}with$c$, because only$c$is referred in the context,\code{c}does not make sense.