Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VIH-10993 Remove obsolete load keyvault file implementation #163

Merged
merged 4 commits into from
Sep 25, 2024

Conversation

shaed-parkar
Copy link
Contributor

@shaed-parkar shaed-parkar commented Sep 23, 2024

Jira link

VIH-10993

Change description

  • reload on config change for secret by file
  • Remove deprecated VH.Core.Configuration

@shaed-parkar shaed-parkar requested review from a team as code owners September 23, 2024 16:44
@shaed-parkar shaed-parkar force-pushed the bugfix/VIH-10993-reload_config_on_change branch from 4a6cae8 to aaa65ff Compare September 24, 2024 08:37
Copy link
Contributor

@oliver-scott oliver-scott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just a couple of comments

NotificationApi/NotificationApi/NotificationApi.csproj Outdated Show resolved Hide resolved
azure-pipelines.sds.pr-release.yml Outdated Show resolved Hide resolved
Shaed Parkar added 2 commits September 24, 2024 16:02
Copy link

sonarcloud bot commented Sep 24, 2024

Copy link
Contributor

@himesh99 himesh99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@shaed-parkar shaed-parkar merged commit a4b31ea into master Sep 25, 2024
15 checks passed
@shaed-parkar shaed-parkar deleted the bugfix/VIH-10993-reload_config_on_change branch September 25, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants