Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VIH-10350 - Decommission obsolete feature flags #159

Merged
merged 10 commits into from
Sep 12, 2024
Merged

VIH-10350 - Decommission obsolete feature flags #159

merged 10 commits into from
Sep 12, 2024

Conversation

marcogagliardi
Copy link
Contributor

Jira link (if applicable)

VIH-10350

Change description

removed feature toggle service

Checklist

  • commit messages are meaningful and follow good commit message guidelines
  • README and other documentation has been updated / added (if needed)
  • tests have been updated / new tests has been added (if needed)
  • Does this PR introduce a breaking change

@marcogagliardi marcogagliardi requested review from a team as code owners June 25, 2024 09:26
@marcogagliardi
Copy link
Contributor Author

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@marcogagliardi
Copy link
Contributor Author

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@marcogagliardi
Copy link
Contributor Author

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

will-craig
will-craig reviewed Jul 12, 2024
View reviewed changes
Copy link
Contributor

@will-craig will-craig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need to remove the whole feature toggle class, just UsePostMay2023Template() from the interface and class

@marcogagliardi
Copy link
Contributor Author

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@marcogagliardi
Copy link
Contributor Author

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@marcogagliardi
Copy link
Contributor Author

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@marcogagliardi
Copy link
Contributor Author

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 11, 2024

Quality Gate Passed Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@marcogagliardi marcogagliardi merged commit aab67eb into master Sep 12, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ronaldmalone ronaldmalone ronaldmalone approved these changes

@shaed-parkar shaed-parkar shaed-parkar approved these changes

@will-craig will-craig will-craig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@marcogagliardi @will-craig @shaed-parkar @ronaldmalone