-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VIH-10353 - Admin web Unable to sent notifications for Edit hearings #149
VIH-10353 - Admin web Unable to sent notifications for Edit hearings #149
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good. We should ideally have tests for the mapper to protect against regression issues. Probably one to tackle through separate tech debt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice. Just added some suggestions
...ificationApi.UnitTests/Mappers/NotificationMappers/MapToHearingAmendmentNotificationTests.cs
Outdated
Show resolved
Hide resolved
...ificationApi.UnitTests/Mappers/NotificationMappers/MapToHearingAmendmentNotificationTests.cs
Outdated
Show resolved
Hide resolved
...ificationApi.UnitTests/Mappers/NotificationMappers/MapToHearingAmendmentNotificationTests.cs
Outdated
Show resolved
Hide resolved
...ificationApi.UnitTests/Mappers/NotificationMappers/MapToHearingAmendmentNotificationTests.cs
Outdated
Show resolved
Hide resolved
…fications-for-Edit-hearings
…-Edit-hearings' of https://github.com/hmcts/vh-notification-api into VIH-10353---Admin-web/-Unable-to-sent-notifications-for-Edit-hearings
Kudos, SonarCloud Quality Gate passed! |
…149) * Update NotificationParameterMapper.cs * added test * Update MapToHearingAmendmentNotificationTests.cs * Update MapToHearingAmendmentNotificationTests.cs
VIH-10353