Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VIH-10353 - Admin web Unable to sent notifications for Edit hearings #149

Conversation

marcogagliardi
Copy link
Contributor

@marcogagliardi marcogagliardi requested review from a team as code owners December 7, 2023 11:58
Copy link
Contributor

@oliver-scott oliver-scott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. We should ideally have tests for the mapper to protect against regression issues. Probably one to tackle through separate tech debt

Copy link
Contributor

@oliver-scott oliver-scott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice. Just added some suggestions

Copy link

sonarcloud bot commented Dec 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@marcogagliardi marcogagliardi merged commit 38c6689 into master Dec 8, 2023
14 checks passed
oliver-scott pushed a commit that referenced this pull request Dec 8, 2023
…149)

* Update NotificationParameterMapper.cs

* added test

* Update MapToHearingAmendmentNotificationTests.cs

* Update MapToHearingAmendmentNotificationTests.cs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants