Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VIH-10352 Send created account email to johs #148

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

oliver-scott
Copy link
Contributor

@oliver-scott oliver-scott commented Dec 7, 2023

Jira link (if applicable)

https://tools.hmcts.net/jira/browse/VIH-10352

Change description

Fixes an issue where new account emails are not sent to johs. Reinstate this functionality, using the Representative email template.

In case it's not clear from the changes - a new test has been added (should_send_a_created_account_email_for_a_judicial_office_holder()) with the same assertions as
should_send_a_created_account_email_for_a_representative()

Copy link

sonarcloud bot commented Dec 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@oliver-scott oliver-scott marked this pull request as ready for review December 7, 2023 10:23
@oliver-scott oliver-scott requested review from a team as code owners December 7, 2023 10:23
Copy link
Contributor

@marcogagliardi marcogagliardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌🏽

@oliver-scott oliver-scott merged commit 2c522ee into master Dec 7, 2023
16 checks passed
@oliver-scott oliver-scott deleted the bug/VIH-10352-create-panel-members branch December 7, 2023 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants