VIH-10899 Delete obsolete V1 operations and models #919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaed-parkar
force-pushed
the
feature/VIH-10899_remove_v1_and_obsolete
branch
from
7b4cdcf
to
9b7d3e3
Compare
will-craig
approved these changes
Nov 27, 2024
Unit tests passing Integration tests passing Yet to refactor AC tests and replace deleted tests
shaed-parkar
force-pushed
the
feature/VIH-10899_remove_v1_and_obsolete
branch
from
57f74ae
to
39b90cc
Compare
Remove HearingNotificationEventForNewJudicialOfficersPublisher
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira link
VIH-10899
Change description
Delete V1 operations and migrate those that still used obsolete models to V2 namespace
More API tests
Package Updates:
System.Text.Jsonpackage version from8.0.0to8.0.5inBookingsApi.Client.csprojandBookingsApi.Common.DotNet6.csprojfiles.Microsoft.Identity.Clientpackage version from4.60.3to4.60.4inBookingsApi.Common.csprojandpackages.lock.jsonfiles.Code Removal:
IVhLoggerandVhLoggerclasses fromBookingsApi.Common.BookingsApi.Contract/V1/RequestsandBookingsApi.Contract/V1/Enums.Refactoring:
AddJusticeUserRequest,GetHearingRequest, and similar classes.File Renaming:
HearingRoles.csfromBookingsApi.DAL/HelpertoBookingsApi.Common.Helpersand added a new constant.