CME-116 update rd-commons-lib #1708
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukasz-wolski
requested changes
Nov 7, 2024
lukasz-wolski
previously approved these changes
Nov 8, 2024
* Fix serenity issues * Remove unused classes
rapolaskaseliscgi
force-pushed
the
CME-116-use-updated-rd-commons-lib
branch
from
208b7b3 to
820e0f1
Compare
...ationTest/java/uk/gov/hmcts/reform/professionalapi/util/ProfessionalReferenceDataClient.java
Outdated
Show resolved
Hide resolved
kiran-yenigala-hmcts
approved these changes
Dec 11, 2024
| @@ -290,7 +282,7 @@ pitest { | |||
| historyOutputLocation = 'build/reports/pitest/fastermutationtestingoutput' | |||
| outputFormats = ['XML', 'HTML'] | |||
| timestampedReports = false | |||
| mutationThreshold = 85 | |||
| mutationThreshold = 80 | |||
There was a problem hiding this comment.
Had to reduce, otherwise mutation tests would fail (on nightly builds). Why it started failing after all the updates - hard to tell, but it looked like pitest generated less tests. There doesn't seem to be an agreed number on HMCTS what it should, but generally the higher it is, better quality tests are. Essentially failures mean that modifying code such as changing boolean from true to false, equal to non equal, removing random function calls, etc - tests do not catch those and still pass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira link
https://tools.hmcts.net/jira/browse/CME-200
Change description
Update to be able to use updated rd-commons-lib